add Nimbus targeting context tables #1209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewilli
approved these changes
May 2, 2025
scholtzan
approved these changes
May 2, 2025
scholtzan
reviewed
May 2, 2025
custom-namespaces.yaml
Outdated
Comment on lines
1029
to
1036
| firefox_ios_targeting_context: | ||
| type: table_view | ||
| tables: | ||
| - table: mozdata.org_mozilla_ios_firefox.nimbus_recorded_targeting_context | ||
| firefox_android_targeting_context: | ||
| type: table_view | ||
| tables: | ||
| - table: mozdata.org_mozilla_fenix.nimbus_recorded_targeting_context |
There was a problem hiding this comment.
Might make sense to add table_explores for these too
b0cbab0 to
e97773e
Compare
|
@mikewilli @scholtzan could you double check that the changes I made make sense? |
mikewilli
requested changes
May 7, 2025
Comment on lines
+1033
to
+1036
| firefox_ios_targeting_context_explore: | ||
| type: table_explore | ||
| views: | ||
| base_view: mozdata.org_mozilla_ios_firefox.nimbus_recorded_targeting_context |
There was a problem hiding this comment.
A couple comments that apply to both of these explores:
- I think they need to go under the
exploressection just below (i.e., same level asexperiment_crash_rateson line 1046) - You don't need to give them a unique name since it's a different type of object (you can omit
_exploreonce it's in theexploressection if you want) - base_view should reference the Looker view as opposed to an actual view in bigquery, (
firefox_ios_targeting_contextfor this one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Nimbus targeting context tables to the experimentation group